Update README.md #4225
Update README.md #4225
Conversation
README.md
Outdated
|
|
||
| [](https://www.warp.dev/?utm_source=github&utm_medium=referral&utm_campaign=fzf)<br> | ||
|
|
||
| ### [Fzf's Terminal of Choice for Developers](https://www.warp.dev/?utm_source=github&utm_medium=referral&utm_campaign=fzf) |
There was a problem hiding this comment.
Thanks. While I greatly appreciate Warp's support to my project, this sentence might feel confusing to the readers because fzf is listed as one of the incompatible tools in your documentation.
- https://docs.warp.dev/help/known-issues#list-of-incompatible-tools
- Fuzzy search causes Warp to freak out warpdotdev/Warp#1647
In a previous email to Tess, I noted that "incompatible" is a strong word, because fzf itself works fine on Warp. What doesn't work is the shell integration part, which is technically an opt-in feature, albeit most users of fzf do enable it.
So until this issue is fixed, I think we should either omit this line or at least tone it down a little bit.
|
One more thing: I noticed the new banner is significantly larger than before, which might be a concern as it overshadows the fzf logo and could distract users. Would it be possible to use a smaller image, similar to the previous size, or perhaps a slightly shorter banner? I also saw that in your previous PR on yazi, you added a sponsor section with a smaller Warp logo. Was this size difference intentional? |
|
Yes! I originally added a larger logo to yazi as well, but the developer preferred a smaller logo so we collaborated together on making it work with the design system of the readme! Happy to make changes to your liking as well! :) |
|
Let me know what you think of the new changes! |
|
LGTM, good to merge! :) |
|
Merged, thanks! |
Let me know what your thoughts are! Happy to make adjustments as needed :)